Ensure we allow component level labels as well as scoped. #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Favour scoped labels.
axfelix
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
LGTM and a helm test is passing. However, I'm honestly not sure how I'm supposed to bootstrap a regular go test in this repo -- it's failing on missing repo sources -- and I'm not very familiar with terratest, but their docs imply I should be able to do that.
asproul
pushed a commit
to asproul/helm-charts
that referenced
this pull request
Dec 16, 2024
…#584) Favour scoped labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Favour scoped labels.
What was changed
Added some tests for server deployment template. Add support for component level resource labels. Favour scoped level resource labels.
Why?
Component level labels were supported but accidentally removed in a PR. Put them back, and add some tests to ensure we don't regress again.
Checklist
Closes
How was this tested: