Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move additionalInitContainers to bottom in server-job.yaml #624

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ragutsky
Copy link

What was changed

Moved admintools.additionalInitContainers to the bottom in server-job.

Why?

Since additional init containers run first there isn't a way to add additional steps to server job after schema setup/update (for instance, add search attributes).

Checklist

  1. Closes -

  2. How was this tested:

  • add value:
admintools:
  additionalInitContainers:
    - name: create-search-attributes
      image: temporalio/admin-tools:1.26.2
      imagePullPolicy: IfNotPresent
      command: ['/bin/sh','-c']
      args: ['temporal operator search-attribute create --namespace "my-namespace" --name="CustomId" --type="Keyword"']
  • run command helm template demo charts/temporal -s templates/server-job.yaml
  • check that added container is at the end
  1. Any docs updates needed?

No

@ragutsky ragutsky requested a review from a team as a code owner January 13, 2025 09:00
@CLAassistant
Copy link

CLAassistant commented Jan 13, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants