Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add errgroup sample #198

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add errgroup sample #198

wants to merge 2 commits into from

Conversation

jackielii
Copy link

@jackielii jackielii commented May 10, 2022

What was changed

add errgroup sample

Why?

errgroup synchronise cancellation is a common pattern.

Checklist

  1. How was this tested:

go run errgroup/errgroup.go

  1. Any docs updates needed?

No other updates needed. Added README.md

@CLAassistant
Copy link

CLAassistant commented May 10, 2022

CLA assistant check
All committers have signed the CLA.

@cretz
Copy link
Member

cretz commented May 16, 2022

Thanks! Can I make a few requests? Firstly, can you split into the starter and worker CLI off as we do in other samples? Second, can you update the root repo README to point to this sample? Finally, can you add a test? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants