Bump SDK to 1.31 #374
Bump SDK to 1.31 #374
Conversation
stephanos
force-pushed
the
bump-1.31
branch
2 times, most recently
from
e2d7fce to
13dd4fa
Compare
There was a problem hiding this comment.
Hm, I copied the code verbatim but it fails. would you know why, @yuandrew?
There was a problem hiding this comment.
hmm, looking, it's not immediately clear why this would suddenly fail, I tested this locally when making the Go SDK change, and it should be a pretty basic UX change, shouldn't be any change to functionality.
Looking at the logs, only 1 activity is completing, instead of the 500 the test expects
There was a problem hiding this comment.
Ok, found the issue, this was due to temporalio/sdk-go#1695 changing test behavior to more closely match how server handles duplicate update IDs. Put the suggested fix in a separate comment.
Thanks for catching this!
There was a problem hiding this comment.
@yuandrew thank you so much!
There was a problem hiding this comment.
@dandavison I revamped this based on your notes and the Java sample.
early-return/starter/main.go
Outdated
| "WorkflowID:", updateHandle.WorkflowID(), | ||
| "RunID:", updateHandle.RunID()) | ||
|
|
||
| var txResult earlyreturn.Transaction |
There was a problem hiding this comment.
I think that we should name this something like earlyReturnResult, or transactionConfirmation, or something else along those lines. The key point we want to get across is that the transaction hasn't completed yet, but txResult suggests otherwise.
There was a problem hiding this comment.
I see what you mean. I can rename it 👍 The java-sample has the same issue.
What was changed