Fixed punctuation in caching.md #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file had inconsistent use of the colon marker when referring to code. Some sentences ended with the colon (":") while others had no punctuation mark.
- Added a colon after "add a line like the following to ~/.bashrc"
- Added a colon after "downloading the models locally with"
- Added a colon after “cache location with code like”
So now the file is consistent with lines that end like:
- “through the Colab host:”
- “workarounds for this situation:”
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thank you @jmarcinowski ! Can you please review the CLA as per the
|
|
Ok, I filled that out. Thank you. |
|
Now the CLA test passes @8bitmp3 |
8bitmp3
approved these changes
Aug 15, 2024
8bitmp3
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file had inconsistent use of the colon mark when referring to code. Some sentences ended with the colon (":") while others had no punctuation mark.
So now the file is consistent with lines that end like: