Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tensorflow version pinning in setup.py #1957

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sdenton4
Copy link

No description provided.

Copy link

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would make sense, but it impact release process as now all these need to be bumped.

Instead we rely on tensorflow specifying the dependency with a pin and users installing only compatible versions

@sdenton4
Copy link
Author

The "users only install compatible versions" is broken from a user-perspective, though - it means downstream users need to keep track of the special constraints between versions of tf and tf-io, and manage the constraints manually. This commonly leads to broken installations and confused users.

The entire point of specifying dependencies explicitly is that they can be handled automatically, as the tooling can automatically find a set of versions satisfying all constraints, without burdening users of libraries depending on your library... I would really advise taking some momentary pain (changing the release process) to make it easier for everyone to use your libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants