Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix training mode for LiRA code at inference #484

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

dedeswim
Copy link
Contributor

While working on a follow-up work to the LiRA and the Truth Serum papers, I realized that, when doing inference to get the model's logits, the model is called in training mode:

logits = model.model(this_x, training=True)

This issue was first raised in #427.

Some of the authors (@carlini and @srxzr) confirmed to me that this is a mistake.

This PR introduces the following changes:

  • Update the way the model is called at inference time
  • Update the results to be expected from the demo runs for both the LiRA and the Truth Serum papers

@shs037 shs037 merged commit fafa69b into tensorflow:master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants