Fix training mode for LiRA code at inference #484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a follow-up work to the LiRA and the Truth Serum papers, I realized that, when doing inference to get the model's logits, the model is called in training mode:
privacy/research/mi_lira_2021/inference.py
Line 72 in 97eec1a
This issue was first raised in #427.
Some of the authors (@carlini and @srxzr) confirmed to me that this is a mistake.
This PR introduces the following changes: