Fix type mismatch warnings #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many files produced many type mismatch warnings with both clang 17 and gcc 14 on a Debian 6.10.11 x86_64 system. This commit fixes almost all the ones I'm seeing in the TFQ code base. Some other warnings still arise in other code and modules. Those warnings don't appear to be things we can easily work around short of creating a lot of patch files (at significant cost in time and testing). For those, I'm currently relying on setting compiler options (e.g., `-Wno-unused-function` for warnings about unused functions) narrowed in scope to the problematic package using Bazel's `--per_file_copt` and `--host_per_file_copt` flags. Those flags are not in this commit; they need to be made part of the TFQ `configure.sh` script.
mhucka
added
kind/chore
MichaelBroughton
previously approved these changes
Jan 6, 2025
| @@ -146,7 +146,7 @@ class TfqPsWeightsFromSymbolOp : public tensorflow::OpKernel { | |||
| auto DoWork2 = [&](int start, int end) { | |||
| for (int i = start; i < end; i++) { | |||
| for (int j = 0; j < n_symbols; j++) { | |||
| for (int k = 0; k < output_results.at(i).at(j).size(); k++) { | |||
| for (size_t k = 0; k < output_results.at(i).at(j).size(); k++) { | |||
There was a problem hiding this comment.
Why do just k and not i, j as well ?
There was a problem hiding this comment.
Ah, that's because k is the only one being compared to a .size() value; i and j are used as indexes.
| @@ -146,7 +146,7 @@ class TfqPsWeightsFromSymbolOp : public tensorflow::OpKernel { | |||
| auto DoWork2 = [&](int start, int end) { | |||
| for (int i = start; i < end; i++) { | |||
| for (int j = 0; j < n_symbols; j++) { | |||
| for (int k = 0; k < output_results.at(i).at(j).size(); k++) { | |||
| for (size_t k = 0; k < output_results.at(i).at(j).size(); k++) { | |||
| output_tensor(i, j, k) = output_results.at(i).at(j).at(k); | |||
| } | |||
| for (int k = output_results.at(i).at(j).size(); | |||
There was a problem hiding this comment.
I agree this one looks inconsistent. It's because in this case, the value of k is being compared to largest_single_symbol on the next line, and that variable is an int.
The weird thing is k is initialized by setting its value to the output of size(), and yet the compiler isn't complaining about that part. I don't have a good explanation for that.
Although the compiler didn't flag them, a couple of declarations that were changed to size_t in a previous commit should probably have const declarations, to be consistent with other changes in the same function.
One of the `size_t` → `int` changes was wrong and led to a test failure. I would prefer to edit the commit itself; however, that would require force-pushing to the TFQ repo, and I'm not sure if that will break the code review comments in the PR in GitHub. So I'm making the change in a separate commit.
MichaelBroughton
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many files produced many type mismatch warnings with both clang 17 and gcc 14 on a Debian 6.10.11 x86_64 system. This commit fixes almost all the ones I'm seeing in the TFQ code base.
Some other warnings still arise in other code and modules. Those warnings don't appear to be things we can easily work around short of creating a lot of patch files (at significant cost in time and testing). For those, I'm currently relying on setting compiler options (e.g.,
-Wno-unused-functionfor warnings about unused functions) narrowed in scope to the problematic package using Bazel's--per_file_coptand--host_per_file_coptflags. Those flags are not in this PR.Note: this PR should be applied after PR #837.