-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EncodeBase64 and DecodeBase64 ops #2004
base: master
Are you sure you want to change the base?
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
c4e602b
to
ec8a768
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
hello @nsthorat @pyu10055 this is a re-submission of the EncodeBase64/DecodeBase64 PRs that were originially in tfjs-core / tfjs-converter / tfjs-node repos and since archived as part of the move to monorepo. is there anything else needed from me here? regarding the build failure, looking at the details/log it shows
i am not sure at first glance how they maybe related to the code changes. is this something i should be trying to investigate further myself? thanks again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm no longer working on this. Please request another reviewer. Thanks!
This is a re-submission of the EncodeBase64/DecodeBase64 PRs that were in
tfjs-core
/tfjs-converter
/tfjs-node
and archived as part of the move to monorepo:the TF implementation of the pix2pix model which fails conversion because of
the Open NSFW model also fails conversion with some of the same ops (#433).
i wanted to try to implement some of these ops in TensorFlow.js. starting with this pull request for DecodeBase64 and EncodeBase64.
To see the logs from the Cloud Build CI, please join either
our discussion
or announcement mailing list.
This change is