-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing workflow and use pytest
#315
Add testing workflow and use pytest
#315
Conversation
b67afcf
to
230e73a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, the amount of code we save from doing test collection with pytest is big. Just a few comments about the dependencies, otherwise this looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Looks like there are also PicklingErrors - are these related to the problem you mentioned? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion, I'm changing this to a request for changes until we understand the PicklingError
.
For now, my plan is to add |
Test workflows are passing now that we xfail and skip classes with failing tests |
Changes have been made
pytest
pytest
this lib is synced from the internal codebase -- the other way does not happen automatically. all the changes will get reverted on the next internal -> github sync. you'd have to make internal change instead |
Do you have access to the internal codebase?
If not, you'd have to ask someone with the access to either:
1) port the PR manually and submit it to the internal codebase, or, since
I'm assuming this is not the last change you're planning to make, it's
better to:
2) configure two-way porting workflow github <-> internal. It would be
quite a bit of work since all migration changes will have to be made
reversible, but in the long run it will allow submitting from github.
…On Thu, Sep 12, 2024 at 5:14 PM William Black ***@***.***> wrote:
this lib is synced from the internal codebase -- the other way does not
happen automatically. all the changes will get reverted on the next
internal -> github sync. you'd have to make internal change instead
@iindyk <https://github.com/iindyk> What would be the best way to have my
and my colleagues' ***@***.*** <https://github.com/peytondmurray>,
@aktech <https://github.com/aktech>) merged into the repo? We're from
Quansight doing consulting for Google.
—
Reply to this email directly, view it on GitHub
<#315 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFQN6OJ3PEYLJ3T74K22ARLZWIU6PAVCNFSM6AAAAABMTDALIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBXGQ2DGMZYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
pytest
pytest
Closing this PR out for now, as there is not currently a path forward for community contributions yet. |
Here is a summary of what is included in this PR:
if __name__ == "__main__"
section from tests because it is not necessary, or even run, when using pytest. Nontrivial functionality from those sections was preserved.README.md
to reflect changesxfail
mark to classes with failing tests