Fix device discovery. #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess maybe Samsung changed the name they return for these, which is what is breaking it for people (including me).
I changed to match on
deviceTypeNameas it seems that would be less mutable. However, I also added matching based on thelabel, which is what we customers name it in the app. This allows users of the plugin to specify the specific name of their device in case the type name matching fails in future (won't require another code change/plugin update).And included some logging around device discovery to help folks identify there's a problem here (or not).
Oh, also reduced the minimum temp, because I actually set mine to 56 at night. No reason I can see not to support lower.