Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add database tags per az, feat: Add public and private and database tags per cidr #905

Closed

Conversation

kahirokunn
Copy link

@kahirokunn kahirokunn commented Mar 6, 2023

Description

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Apr 6, 2023
@kahirokunn
Copy link
Author

keep

@bryantbiggs
Copy link
Member

thank you but this is not something we will be adding to the module at this time

@bryantbiggs bryantbiggs closed this Apr 6, 2023
@kahirokunn
Copy link
Author

@bryantbiggs May I ask why you don't tag them?

@bryantbiggs
Copy link
Member

because its not a pattern we commonly see used nor do I think its a pattern that we would want to promote (in the world of IPAM and dynamic IP assignment, this will fail horribly)

@kahirokunn
Copy link
Author

@bryantbiggs #901

If so, how about this one?
I feel this style of code is common.

@bryantbiggs
Copy link
Member

that PR is entirely different - it does not rely on computed values as keys to a map

@kahirokunn
Copy link
Author

I see. Thx.

@github-actions
Copy link

github-actions bot commented May 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants