Compiler warnings cleanup

tesseract-clickhouse/src/sql/rate.rs

@@ -41,7 +41,7 @@ pub fn rate_calculation(
         primary_agg(table, cuts, &new_drills, meas, None)
     };
 
-    let mut rate_sql = "".to_string();
+    let mut rate_sql;
 
     // Wrap that around a pivot
     let original_drill_cols = drills.iter().map(|drill| drill.col_alias_only_string());

tesseract-core/src/backend.rs

@@ -14,7 +14,7 @@ pub trait Backend {
     /// Takes in a SQL string, outputs a stream of
     /// DataFrames, which will go on to be formatted into the
     /// desired query output format.
-    fn exec_sql_stream(&self, sql: String) -> Box<dyn Stream<Item=Result<DataFrame, Error>, Error=Error>> {
+    fn exec_sql_stream(&self, _sql: String) -> Box<dyn Stream<Item=Result<DataFrame, Error>, Error=Error>> {
         unimplemented!()
     }
 

tesseract-core/src/format_stream.rs

@@ -1,6 +1,6 @@
 use bytes::Bytes;
 use csv;
-use failure::{Error, format_err};
+use failure::Error;
 use futures::{Stream, Async, Poll};
 use indexmap::IndexMap;
 use serde::Serializer;
@@ -117,8 +117,7 @@ impl<S> Stream for RecordBlockStream<S>
 
                     self.sent_header = true;
                     return Ok(Async::Ready(Some(bytes)));
-                },
-                _ => return Err(format_err!("just csv first")),
+                }
             }
         }
 
@@ -147,8 +146,7 @@ impl<S> Stream for RecordBlockStream<S>
                         FormatType::JsonArrays => {
                             let res = b"]}".to_vec().into();
                             return Ok(Async::Ready(Some(res)));
-                        },
-                        _ => return Err(format_err!("just csv first")),
+                        }
                     }
                 },
             };
@@ -198,7 +196,6 @@ impl<S> Stream for RecordBlockStream<S>
 
                             return Ok(Async::Ready(Some(body)));
                         }
-                        _ => return Err(format_err!("just csv first")),
                     };
 
                     return Ok(Async::Ready(Some(formatted)));

tesseract-core/src/lib.rs

@@ -1257,7 +1257,7 @@ impl Schema {
         Ok(column)
     }
 
-    fn get_mea_col(&self, cube_name: &str, measure: &Measure) -> Result<String, Error> {
+    /* fn get_mea_col(&self, cube_name: &str, measure: &Measure) -> Result<String, Error> {
         let cube = self.cubes.iter()
             .find(|cube| &cube.name == &cube_name)
             .ok_or(format_err!("Could not find cube"))?;
@@ -1269,7 +1269,7 @@ impl Schema {
         let column = mea.column.clone();
 
         Ok(column)
-    }
+    } */
 
     pub fn get_cube_by_name(&self, cube_name: &str) -> Result<&Cube, Error> {
         self.cubes.iter()

tesseract-mysql/src/df.rs

@@ -8,7 +8,7 @@ use mysql_async::Value::*;
 use std::str;
 use tesseract_core::{DataFrame, Column, ColumnData};
 
-pub fn rows_to_df(query_result: QueryResult<Conn, BinaryProtocol>) -> Box<Future<Item=DataFrame, Error=Error>> {
+pub fn rows_to_df(query_result: QueryResult<Conn, BinaryProtocol>) -> Box< dyn Future<Item=DataFrame, Error=Error>> {
     let mut tcolumn_list = vec![];
     let columns = query_result.columns_ref();
 

tesseract-mysql/src/lib.rs

@@ -26,7 +26,7 @@ impl MySql {
 }
 
 impl Backend for MySql {
-    fn exec_sql(&self, sql: String) -> Box<Future<Item=DataFrame, Error=Error>> {
+    fn exec_sql(&self, sql: String) -> Box< dyn Future<Item=DataFrame, Error=Error>> {
         let future = self.pool.get_conn()
             .and_then(move |conn| {
                 conn.prep_exec(sql.to_string(), ())

tesseract-postgres/src/lib.rs

@@ -55,7 +55,7 @@ impl Postgres {
 // 2. dataframe creation
 
 impl Backend for Postgres {
-    fn exec_sql(&self, sql: String) -> Box<Future<Item=DataFrame, Error=Error>> {
+    fn exec_sql(&self, sql: String) -> Box< dyn Future<Item=DataFrame, Error=Error>> {
         let fut = self.pool.run(move |mut connection| {
             connection.prepare(&sql).then( |r| match r {
                 Ok(select) => {

tesseract-server/src/handlers/diagnosis.rs

@@ -1,4 +1,3 @@
-use std::collections::HashMap;
 use std::str;
 
 use actix_web::{
@@ -7,22 +6,18 @@ use actix_web::{
     Path,
     Result as ActixResult,
 };
-use failure::{Error, format_err};
+use failure::Error;
 use futures::future::Future;
 use lazy_static::lazy_static;
 use log::*;
 use serde_qs as qs;
 use serde_derive::Deserialize;
-use url::Url;
 
-use tesseract_core::names::{Property, LevelName};
 use tesseract_core::format::{format_records, FormatType};
 use tesseract_core::{DataFrame, Column, ColumnData};
-use tesseract_core::schema::{Cube, DimensionType, Level};
+use tesseract_core::schema::{Cube, Level};
 use crate::app::AppState;
-use crate::logic_layer::{LogicLayerConfig, CubeCache};
 use crate::handlers::util::{verify_authorization, format_to_content_type};
-use crate::handlers::logic_layer::{query_geoservice, GeoserviceQuery};
 
 
 /// Handles default aggregation when a format is not specified.
@@ -37,7 +32,7 @@ pub fn diagnosis_default_handler(
 
 /// Handles aggregation when a format is specified.
 pub fn diagnosis_handler(
-    (req, cube_format): (HttpRequest<AppState>, Path<(String)>)
+    (req, cube_format): (HttpRequest<AppState>, Path<String>)
 ) -> ActixResult<HttpResponse>
 {
     perform_diagnosis(req, cube_format.to_owned())
@@ -99,7 +94,7 @@ pub fn perform_diagnosis(
             let mut error_messages: Vec<String> = vec![];
 
             for cube in &schema.cubes {
-                if let Err(err) = verify_authorization(&req, cube.min_auth_level) {
+                if let Err(_err) = verify_authorization(&req, cube.min_auth_level) {
                     continue;
                 }
 
@@ -109,7 +104,7 @@ pub fn perform_diagnosis(
                 if new_error_types.len() != 0 {
                     let mut new_error_cubes: Vec<String> = vec![];
 
-                    for i in 0..new_error_types.len() {
+                    for _i in 0..new_error_types.len() {
                         new_error_cubes.push(cube.name.clone());
                     }
 
@@ -171,7 +166,7 @@ fn diagnose_cube(req: &HttpRequest<AppState>, cube: &Cube) -> (Vec<String>, Vec<
                                 None => ()
                             }
                         },
-                        Err(err) => ()
+                        Err(_err) => ()
                     }
 
                     // Check for `NonUniqueDimensionIDs`
@@ -204,7 +199,7 @@ fn diagnose_cube(req: &HttpRequest<AppState>, cube: &Cube) -> (Vec<String>, Vec<
                                 None => ()
                             }
                         },
-                        Err(err) => ()
+                        Err(_err) => ()
                     }
                 }
             }

tesseract-server/src/handlers/logic_layer/aggregate.rs

@@ -65,7 +65,7 @@ pub fn logic_layer_default_handler(
 
 /// Handles aggregation when a format is specified.
 pub fn logic_layer_handler(
-    (req, cube_format): (HttpRequest<AppState>, Path<(String)>)
+    (req, cube_format): (HttpRequest<AppState>, Path<String>)
 ) -> FutureResponse<HttpResponse>
 {
     logic_layer_aggregation(req, cube_format.to_owned())

tesseract-server/src/handlers/logic_layer/metadata.rs

@@ -36,7 +36,7 @@ pub fn logic_layer_members_default_handler(
 
 /// Handles members query when a format is specified.
 pub fn logic_layer_members_handler(
-    (req, cube_format): (HttpRequest<AppState>, Path<(String)>)
+    (req, cube_format): (HttpRequest<AppState>, Path<String>)
 ) -> FutureResponse<HttpResponse>
 {
     get_members(req, cube_format.to_owned())

tesseract-server/src/handlers/logic_layer/mod.rs

@@ -37,7 +37,7 @@ pub fn logic_layer_non_unique_levels_default_handler(
 
 
 pub fn logic_layer_non_unique_levels_handler(
-    (req, _cube): (HttpRequest<AppState>, Path<(String)>),
+    (req, _cube): (HttpRequest<AppState>, Path<String>),
     ) -> HttpResponse
 {
     if req.state().debug {
@@ -71,7 +71,7 @@ pub fn logic_layer_relations_non_unique_levels_default_handler(
 
 
 pub fn logic_layer_relations_non_unique_levels_handler(
-    (req, _cube): (HttpRequest<AppState>, Path<(String)>),
+    (req, _cube): (HttpRequest<AppState>, Path<String>),
     ) -> HttpResponse
 {
     if req.state().debug {

tesseract-server/src/handlers/logic_layer/relations.rs

@@ -36,7 +36,7 @@ pub fn logic_layer_relations_default_handler(
 
 /// Handles aggregation when a format is specified.
 pub fn logic_layer_relations_handler(
-    (req, cube_format): (HttpRequest<AppState>, Path<(String)>)
+    (req, cube_format): (HttpRequest<AppState>, Path<String>)
 ) -> ActixResult<HttpResponse>
 {
     logic_layer_relations(req, cube_format.to_owned())