Different open and close delimiters #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchanns
approved these changes
May 16, 2024
|
LGTM. Just one more step left. Could you please sign all your commits with the GPG key? FYI: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
I didn't notice that I have to do it 🫠 |
Jawell
force-pushed
the
different-start-and-end-delimiters
branch
from
55952dd to
6af54d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JS library allows the use of different delimiters for the start and the end: https://www.npmjs.com/package/gray-matter#optionsdelimiters
What do you think? Could we add the same functionality?