Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7: Adding list filtering #29

Merged
merged 14 commits into from
Sep 1, 2024
Merged

Conversation

bbland1
Copy link
Collaborator

@bbland1 bbland1 commented Aug 29, 2024

For an example of how to fill this template out, see this Pull Request.

Description

Allowing users to search through their list will help them cut down on clutter and focus on items they’re looking for.

Related Issue

Closes #7

Acceptance Criteria

  • A form is added to the top of the List view, above the shopping list
  • The form includes the following elements
    • A text field (with semantic <label>!) which narrows down the list as the user types
    • When there’s text in the field, some kind of button (e.g., an X) to clear the field. When the field is cleared, the list is reset to its unfiltered state.

Type of Changes

Type
💯 Enhancement
✨ New Feature

Updates

Before

Screenshot 2024-08-28 at 10 22 40 PM

After

Screen.Recording.2024-08-28.at.10.22.56.PM.mov

Testing Steps / QA Criteria

  • Visit the preview URL for this PR
  • Sign in to the application
  • Click a list that you want view on homepage
  • Navigate to list view
  • Type into the the search bar at the top of the list
  • Hit the x in the box when ready to clear the search

Copy link

github-actions bot commented Aug 29, 2024

Visit the preview URL for this PR (updated for commit 243b675):

https://tcl-77-smart-shopping-list--pr29-fz-bb-filter-shoppin-jmib3sm3.web.app

(expires Sun, 08 Sep 2024 05:45:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b77df24030dca7d8b6561cb24957d2273c5e9d72

@bbland1 bbland1 marked this pull request as ready for review August 29, 2024 02:31
package.json Show resolved Hide resolved
src/views/List.tsx Outdated Show resolved Hide resolved
src/views/List.tsx Outdated Show resolved Hide resolved
src/components/FilterList.tsx Outdated Show resolved Hide resolved
src/components/FilterList.tsx Outdated Show resolved Hide resolved
src/views/List.tsx Outdated Show resolved Hide resolved
src/views/List.tsx Outdated Show resolved Hide resolved
src/views/List.tsx Outdated Show resolved Hide resolved
@tannaurus
Copy link
Collaborator

Left some tiny thoughts but approved! Great work!

src/App.tsx Outdated Show resolved Hide resolved
src/views/List.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was such a thoughtful addition!!!! big praise!! I like that you added this because it keeps the user experience in mind.

Copy link
Collaborator

@eternalmaha eternalmaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job Yall!!! I really enjoyed watching the issue expand and evolve as the days went on!! Seems like you guys experimented with a lot

src/components/FilterListInput.tsx Show resolved Hide resolved
src/components/FilterList.tsx Outdated Show resolved Hide resolved
@zahrafalak zahrafalak merged commit a1086ef into main Sep 1, 2024
2 checks passed
@zahrafalak zahrafalak deleted the fz-bb-filter-shopping-list branch September 1, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7. As a user, I want to filter my shopping list to make it easier to locate an item in the list
5 participants