-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 7: Adding list filtering #29
Conversation
Co-authored-by: Falak <[email protected]>
Co-authored-by: Falak <[email protected]>
Visit the preview URL for this PR (updated for commit 243b675): https://tcl-77-smart-shopping-list--pr29-fz-bb-filter-shoppin-jmib3sm3.web.app (expires Sun, 08 Sep 2024 05:45:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b77df24030dca7d8b6561cb24957d2273c5e9d72 |
Left some tiny thoughts but approved! Great work! |
…ending list and the filtering input
…ays if filter list is empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was such a thoughtful addition!!!! big praise!! I like that you added this because it keeps the user experience in mind.
…necessary re-renders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job Yall!!! I really enjoyed watching the issue expand and evolve as the days went on!! Seems like you guys experimented with a lot
For an example of how to fill this template out, see this Pull Request.
Description
Allowing users to search through their list will help them cut down on clutter and focus on items they’re looking for.
Related Issue
Closes #7
Acceptance Criteria
List
view, above the shopping list<label>
!) which narrows down the list as the user typesType of Changes
Updates
Before
After
Screen.Recording.2024-08-28.at.10.22.56.PM.mov
Testing Steps / QA Criteria
x
in the box when ready to clear the search