Fix joins readme & new test case (#37)

the-tinderbox · Jan 17, 2021 · 8da8546 · 8da8546
1 parent 5441f01
commit 8da8546
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -158,8 +158,8 @@ SELECT * FROM `table` GLOBAL ANY LEFT JOIN `another_table` AS `alias` USING `col
 For performing subquery as first argument you can pass closure or builder.
 
 ```php
-$builder->from('table')->join(function ($query) {
-    $query->select('column1', 'column2')->from('table2');
+$builder->from('table')->join(function ($join) {
+    $join->query()->select('column1', 'column2')->from('table2');
 }, 'any', 'left', ['column1', 'column2']);
 
 $builder->from('table')->join($builder->select('column1', 'column2')->from('table2'), 'any', 'left', ['column1', 'column2']);

diff --git a/tests/BuilderTest.php b/tests/BuilderTest.php
@@ -397,6 +397,11 @@ public function test_join_with_closure()
 
         $builder = $this->getBuilder()->anyLeftJoin($this->getBuilder()->from('table'), ['column']);
         $this->assertEquals('SELECT * ANY LEFT JOIN (SELECT * FROM `table`) USING `column`', $builder->toSql());
+
+        $builder->from('table')->join(function ($join) {
+            $join->query()->select('column1', 'column2')->from('table2');
+        }, 'any', 'left', ['column1', 'column2']);
+        $this->assertEquals('SELECT * FROM `table` ANY LEFT JOIN (SELECT `column1`, `column2` FROM `table2`) USING `column1`, `column2`', $builder->toSql());
     }
 
     public function test_preWheres()