Reset order by before count(). #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StyxOfDynamite
commented
Jul 19, 2022
|
|
||
| if (empty($this->groups)) { | ||
| $without['orders'] = []; | ||
| } |
There was a problem hiding this comment.
This is the only real code change, the rest was generated by applying the diff supplied by Style CI.
There is also a change to the tests I've highlighted further down.
StyxOfDynamite
commented
Jul 19, 2022
| @@ -703,7 +703,7 @@ public function test_count() | |||
| $this->assertEquals('SELECT count() as `count` FROM `table`', $builder->toSql()); | |||
|
|
|||
| $builder = $this->getBuilder()->from('table')->select('column1', 'column2', 'column3')->groupBy('column2')->orderBy('column1')->limit(10)->getCountQuery(); | |||
| $this->assertEquals('SELECT count() as `count` FROM `table` GROUP BY `column2` ORDER BY `column1` ASC', $builder->toSql()); | |||
| $this->assertEquals('SELECT count() as `count` FROM `table` GROUP BY `column2`', $builder->toSql()); | |||
There was a problem hiding this comment.
This change updates the test so as not to check for ORDER BY when doing a count()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses my comment on #56
In my case, a
selectcolumn exist that applies an alias, that alias is then used in theorderBy, when fetching acount()query, the select columns are rewritten, but not theorderBythat references them.