-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET 9 Support #148
base: main
Are you sure you want to change the base?
.NET 9 Support #148
Conversation
Upgraded everything to .net9, I couldn't get the package props working with my stuff so I've just axed it for now
The bottom sheet no longer crashes when presenting
Since i couldn't get this working earlier and deleted the package.props file, I've restored it and fixed my issues!
Increase major version due to .net 9 upgrade
I added these other platforms when trying to get .NET 9 working, now its all sorted we dont need them!
I've found the source of the iOS ratio detent crash, the following method runs forever and causes a deadlock in the application. Will put a fix in with this PR! |
There was a loop where when creating custom detent sizes, the layout views would enter a doom loop which would deadlock the ui thread.
When will this be merged into the main branch and update the nuget repo? Waiting to implement this into my .NET 9 android app! |
my thoughts exactly. it doesn't work as in example. namespace is not same
…On Mon, Jan 27, 2025 at 10:11 AM Jonathan Öhrström ***@***.***> wrote:
When will this be merged into the main branch and update the nuget repo?
Waiting to implement this into my .NET 9 android app!
—
Reply to this email directly, view it on GitHub
<#148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4GHIE7BEHSHOLSF4NRETGL2MXZ5PAVCNFSM6AAAAABVTULTV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJVGIYDENBQGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I'm currently investigating an issue where bottom sheets on android don't present when you're in a modal page. They get presented at the bottom level of your modal stack. Trying to see what I can do to fix & will update this PR when I work it out. I did try seeing if the issue is present in the Softlion version & its also there 😨 For any of you looking to use this, my advice would be either to pull the project source into your project & build it locally with your project, or build the package and host it somewhere thats what I'm doing! |
don't forget we are now using .net 9 which is different from the source of
the original project so adding it to our project will require lots of
upgrade(libraries)
…On Mon, Jan 27, 2025 at 10:50 AM Axemasta ***@***.***> wrote:
I'm currently investigating an issue where bottom sheets on android don't
present when you're in a modal page.
They get presented at the bottom level of your modal stack. Trying to see
what I can do to fix & will update this PR when I work it out. I did try
seeing if the issue is present in the Softlion version & its also there 😨
For any of you looking to use this, my advice would be either to pull the
project source into your project & build it locally with your project, or
build the package and host it somewhere thats what I'm doing!
—
Reply to this email directly, view it on GitHub
<#148 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4GHIEYF3O4NUNNIEQY76TD2MX6NHAVCNFSM6AAAAABVTULTV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJVGI4DKMBWGM>
.
You are receiving this because you commented.Message ID: <the49ltd/The49.
***@***.***>
|
@Axemasta don't know if its interesting for you but I built a BottomSheet control aswell for .net 8. I just finished a big rework for .net 9 including non modals. The BottomSheets also work when you are in a modal page because I use Googles BottomSheetDialog under the hood. The APIs between this and my package differ a bit but probably it works for you. |
@lucacivale thanks, I am aware of your library and have been using your android implementation as part of the modal fix for the issue I've found on android. Your library is very well presented however porting our main app to your library might be quite painful mostly due to the navigation changes. For this library we've built a custom navigation service which works a treat and unfortunately your libraries I've currently got the android |
The library currently doesn't work on .NET 9 for android due to
BottomSheetBehavior
moving tocom.google.android.material.bottomsheet.BottomSheetBehavior
. This has been reported in #142 and has been addressed in this PR.Changes:
RatioDetent
with value not equal to0.6f
, this was caused by a recurisve layout loop kicking off infinite calls toLayout
&LayoutSubViews
. This was not an issue in .NET 8!9.0.0