AutoNav #175
Open
AutoNav #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auscompgeek
reviewed
Mar 7, 2021
| reversed: bool | ||
|
|
||
| def __init__(self, points, reversed) -> None: | ||
| self.start, *self.waypoints, self.end = points |
There was a problem hiding this comment.
Since points isn't a homogeneous list, would it be better to just pass in start and end separately? (At which point it'd be worth making this a dataclass.)
Comment on lines
+16
to
+18
| reversed: bool | ||
|
|
||
| def __init__(self, points, reversed) -> None: |
There was a problem hiding this comment.
Should reversed have a default?
Open
Co-authored-by: David Vo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AutoNav code has become the basis of our new auto routines, I think it should be reviewed separately so that expansions on it become more manageable.