Add Secure Boot for Satellite and RHEL #3488
Open
+57
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR preview for 90759c5 could not be generated |
Lennonka
force-pushed
the
add-secureboot-rhel
branch
from
86fb5e0 to
a7b41a3
Compare
|
Rebased. |
Lennonka
added
Needs tech review
There was a problem hiding this comment.
diff and rendered docs LGTM.
The only minor improvement that I see is "My_Operating_System_in_Lowercase". Maybe you want to introduce an attribute for that? Your call.
I am currently unsure why we didn't do that in the first place. If you're interested, I could ping people that implemented this in the beginning of January.
maximiliankolb
added
style review done
Lennonka
commented
Dec 18, 2024
nofaralfasi
reviewed
Jan 12, 2025
There was a problem hiding this comment.
If I understand correctly, this PR adds instructions on configuring Secure Boot for other OS versions. However, we decided this is no longer necessary, as the same GRUB and shim can be used across multiple RHEL versions.
cc: @stejskalleos
Lennonka
commented
Jan 13, 2025
Lennonka
force-pushed
the
add-secureboot-rhel
branch
from
a7b41a3 to
029af2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Adding Secure Boot support for Satellite and RHEL.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
SAT-23035 Epic
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: N/A - for 3.14