-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing steps for disabling TFTP and DNS #3509
base: master
Are you sure you want to change the base?
Add missing steps for disabling TFTP and DNS #3509
Conversation
The PR preview for 49f1757 is available at theforeman-foreman-documentation-preview-pr-3509.surge.sh The following output files are affected by this PR: |
guides/common/modules/proc_disabling-dns-dhcp-tftp-for-unmanaged-networks.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_disabling-dns-dhcp-tftp-for-unmanaged-networks.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this change is correct, but the whole file is confusing in its purpose.
If we analyze the title and the first sentence, that's:
Disabling DNS, DHCP, and TFTP for unmanaged networks
If you want to manage TFTP, DHCP, and DNS services manually, you must prevent {Project} from maintaining these services on the operating system and disable orchestration to avoid DHCP and DNS validation errors.
So the purpose is to have services installed, but managed manually by sysadmin. Then an instruction is given to disable the Foreman Proxy features (DHCP, DNS, TFTP). This effectively means the services may still run, but at least Foreman no longer orchestrates them.
If the intent was to let the sysadmin manage these services themselves, then that should be sufficient. Masking them would be part of a procedure to really remove the services, but I don't think we document that at all today.
guides/common/modules/proc_disabling-dns-dhcp-tftp-for-unmanaged-networks.adoc
Show resolved
Hide resolved
guides/common/modules/proc_disabling-dns-dhcp-tftp-for-unmanaged-networks.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_disabling-dns-dhcp-tftp-for-unmanaged-networks.adoc
Outdated
Show resolved
Hide resolved
@@ -15,9 +19,11 @@ However, {Project} does not remove the back-end services on the operating system | |||
--foreman-proxy-tftp false | |||
---- | |||
|
|||
. In the {ProjectWebUI}, navigate to *Infrastructure* > *Subnets* and select a subnet. | |||
. For every subnet where the {SmartProxy} is set as a TFTP proxy, disable the proxies: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DHCP, DNS, or TFTP. Also, proxy is an upstream word and I don't know for sure how this is branded in downstream.
What changes are you introducing?
Adding missing steps for disabling TFTP and DNS for unmanaged networks.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
https://issues.redhat.com/browse/SAT-18574
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: