Add option set new HTTP proxy as default #3510
Merged
+20
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lennonka
force-pushed
the
add-option-set-default-http-proxy
branch
from
cda1ecb to
425ee8d
Compare
|
The PR preview for 01a597d is available at theforeman-foreman-documentation-preview-pr-3510.surge.sh The following output files are affected by this PR:
|
Lennonka
added
Needs tech review
asteflova
approved these changes
Dec 10, 2024
asteflova
added
style review done
Lennonka
added
tech review done
Lennonka
commented
Dec 10, 2024
maximiliankolb
approved these changes
Dec 10, 2024
|
Please, keep it open for a QE review. |
|
@Gauravtalreja1 This procedure is awaiting QE testing. Please, leave a comment. Thank you! |
Lennonka
force-pushed
the
add-option-set-default-http-proxy
branch
from
ecaff9b to
b3b8e09
Compare
|
Rebased. |
Lennonka
added
the
Waiting for code
|
Waiting for the merge of Katello/katello#11266 |
|
Katello/katello#11266 has been merged! |
Lennonka
removed
the
Waiting for code
|
@Gauravtalreja1 Can you give it a final ack? |
Comment on lines
40
to
41
| --url http://_http-proxy.example.com_:8080 | ||
| --content_default_http_proxy |
There was a problem hiding this comment.
Just a small change in command, and not sure if we should include --organization "My_Organization" --location "My_Location" here as well
Suggested change
| --url http://_http-proxy.example.com_:8080 | |
| --content_default_http_proxy | |
| --url http://_http-proxy.example.com_:8080 \ | |
| --content-default-http-proxy true |
There was a problem hiding this comment.
I'm not sure about org and loc either, but I'd say it's out of scope.
Lennonka
force-pushed
the
add-option-set-default-http-proxy
branch
from
b3b8e09 to
01a597d
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Replacing manual configuration of the default content HTTP proxy with a new option to configure the global setting automatically.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Documents theforeman/foreman#10372, Katello/katello#11183, and Katello/katello#11266
https://issues.redhat.com/browse/SAT-28860 (public)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: N/A