Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv4 installation requirements #3553

Merged

Conversation

aneta-petrova
Copy link
Member

What changes are you introducing?

Adding details on requirements for installation in an IPv4 network.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

https://issues.redhat.com/browse/SAT-29764 requests adding this.

I started working on this in #3545 but actually want to get it merged in a separate PRs due to different cherry-pick requirements.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

N/A

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@aneta-petrova aneta-petrova added the Needs style review Requires a review from docs style/grammar perspective label Jan 8, 2025
@aneta-petrova
Copy link
Member Author

This was tech acked in #3545 (comment)

@aneta-petrova aneta-petrova added the tech review done No issues from the technical perspective label Jan 8, 2025
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lennonka Lennonka added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Jan 8, 2025
@aneta-petrova aneta-petrova merged commit 0add510 into theforeman:master Jan 10, 2025
9 checks passed
@aneta-petrova aneta-petrova deleted the ipv4_installation_requirements branch January 10, 2025 10:00
aneta-petrova added a commit that referenced this pull request Jan 10, 2025
aneta-petrova added a commit that referenced this pull request Jan 10, 2025
aneta-petrova added a commit that referenced this pull request Jan 10, 2025
aneta-petrova added a commit that referenced this pull request Jan 10, 2025
aneta-petrova added a commit that referenced this pull request Jan 10, 2025
aneta-petrova added a commit that referenced this pull request Jan 10, 2025
aneta-petrova added a commit that referenced this pull request Jan 10, 2025
@aneta-petrova
Copy link
Member Author

Merged to "master" and cherry-picked:

eb2cfa7..17fb515 3.13 -> 3.13
498cd50..ca3d11a 3.12 -> 3.12
985b97b..d7502a3 3.11 -> 3.11
0b9ebac..8632767 3.10 -> 3.10
f608bb8..e812d90 3.9 -> 3.9
938b140..d701cbf 3.8 -> 3.8
21368d2..2552935 3.7 -> 3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants