-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPv4 installation requirements #3553
Merged
aneta-petrova
merged 1 commit into
theforeman:master
from
aneta-petrova:ipv4_installation_requirements
Jan 10, 2025
Merged
Add IPv4 installation requirements #3553
aneta-petrova
merged 1 commit into
theforeman:master
from
aneta-petrova:ipv4_installation_requirements
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR preview for 4ad5f65 is available at theforeman-foreman-documentation-preview-pr-3553.surge.sh The following output files are affected by this PR: |
9 tasks
This was tech acked in #3545 (comment) |
Lennonka
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
maximiliankolb
approved these changes
Jan 9, 2025
aneta-petrova
added a commit
that referenced
this pull request
Jan 10, 2025
(cherry picked from commit 0add510)
aneta-petrova
added a commit
that referenced
this pull request
Jan 10, 2025
(cherry picked from commit 0add510)
aneta-petrova
added a commit
that referenced
this pull request
Jan 10, 2025
(cherry picked from commit 0add510)
aneta-petrova
added a commit
that referenced
this pull request
Jan 10, 2025
(cherry picked from commit 0add510)
aneta-petrova
added a commit
that referenced
this pull request
Jan 10, 2025
(cherry picked from commit 0add510)
aneta-petrova
added a commit
that referenced
this pull request
Jan 10, 2025
(cherry picked from commit 0add510)
aneta-petrova
added a commit
that referenced
this pull request
Jan 10, 2025
(cherry picked from commit 0add510)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
style review done
No issues from docs style/grammar perspective
tech review done
No issues from the technical perspective
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Adding details on requirements for installation in an IPv4 network.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
https://issues.redhat.com/browse/SAT-29764 requests adding this.
I started working on this in #3545 but actually want to get it merged in a separate PRs due to different cherry-pick requirements.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
N/A
Checklists
Please cherry-pick my commits into: