Drop instructions to update grub2-efi #3554
Merged
+0
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can tell this was needed in the past because RHEL 7.9 contained an updated grub2-efi with support for HTTPBoot. Now that EL7 has been dropped, this is irrelevant and any installed version will do. The installer when enabling the tftp feature the already guarantees that the package is installed so the instruction can be dropped.
maximiliankolb
approved these changes
Jan 9, 2025
maximiliankolb
added
the
style review done
|
@Lennonka FYI |
Lennonka
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
As the title says: it drops the manual instruction to install/update the grub2-efi package.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
As far as I can tell this was needed in the past because RHEL 7.9 contained an updated grub2-efi with support for HTTPBoot. Now that EL7 has been dropped, this is irrelevant and any installed version will do. The installer when enabling the tftp feature the already guarantees that the package is installed so the instruction can be dropped.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
I only selected Foreman 3.13 as a cherry pick so we don't modify existing Satellite releases, but it's probably safe there as well.
Checklists
Please cherry-pick my commits into: