-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overview of preparing for DR #3558
base: master
Are you sure you want to change the base?
Conversation
The PR preview for 269a7ea is available at theforeman-foreman-documentation-preview-pr-3558.surge.sh The following output files are affected by this PR: |
This is just a first draft so things might still change a lot. But I wanted to open it up for early feedback in case anyone notices anything particularly concerning. |
da0c462
to
70f3e50
Compare
Hi @ehelms, can you please review? This is just a prettified version of the draft you shared but I did fill in a few of my own assumptions that need checking. If this gets merged, I would like to follow up with more detailed instructions for each of the scenarios, see the PR's description. |
70f3e50
to
fb8798d
Compare
guides/common/modules/con_overview-of-recommended-disaster-recovery-plans.adoc
Show resolved
Hide resolved
guides/common/modules/con_overview-of-recommended-disaster-recovery-plans.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two minor suggestions, rest LGTM style-wise.
the overall style is quite different to our documentation but I like it!
guides/common/modules/con_overview-of-recommended-disaster-recovery-plans.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_overview-of-recommended-disaster-recovery-plans.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Maximilian Kolb <[email protected]>
01b4426
to
93df98c
Compare
Thanks for the comments @ehelms, I applied your feedback. Can you please re-review and tell me if you have any more? |
I think it's looking good, as the original author of the content, I'd like to get a review from @evgeni. |
It would indeed be great if we could add pros/cons. "What is the expected impact?" was my take on the cons. One of my earliest drafts also included "When should I choose this option?", which would correspond to pros, but I didn't know what to fill in. |
Maybe to add some notes from my experience with different customers:
|
guides/common/modules/con_overview-of-recommended-disaster-recovery-plans.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_overview-of-recommended-disaster-recovery-plans.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_overview-of-recommended-disaster-recovery-plans.adoc
Show resolved
Hide resolved
guides/common/modules/con_overview-of-recommended-disaster-recovery-plans.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_overview-of-recommended-disaster-recovery-plans.adoc
Outdated
Show resolved
Hide resolved
Because I finally installed a spell checker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented part of the feedback, some of it only as comments.
As stated in the PR's description, I intend to follow up on this PR with others that will provide actual DR procedures with actionable steps for users to take. The lines that are commented out seem like a better fit for such procedures so I want to add them only as internal notes for now.
guides/common/modules/con_overview-of-recommended-disaster-recovery-plans.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_overview-of-recommended-disaster-recovery-plans.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_overview-of-recommended-disaster-recovery-plans.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/con_overview-of-recommended-disaster-recovery-plans.adoc
Outdated
Show resolved
Hide resolved
c023bd0
to
aed815f
Compare
This is great feedback, thank you!
I think all of this will be most useful to document in a subsequent PR where I intend to describe the actual steps/procedures users need to take when implementing their preferred DR scenario. Perhaps as best practices/recommendations? So I won't work this in just yet and will wait until I start working on the procedures.
Yes!! :) I would very much like to include some testing steps -- not in this PR but in those subsequent PRs I mentioned (see also this PR's description for hints on what I'm planning next). Some sort of verification procedure or a checklist that will help users verify that they are well prepared is certainly a good idea. |
I resolved all comments and hopefully implemented all your feedback @ehelms and @evgeni. Can you please re-review? Note that some lines are now commented out. I intend to use them in follow-up PRs that will introduce DR procedures. I'd like to keep this PR limited strictly to an overview (= brief descriptions and pros/cons). I also added sections for Advantages of each DR scenario. They are currently empty because I don't know what these pros/advantages are. Can you please help with that? |
guides/common/modules/con_overview-of-recommended-disaster-recovery-plans.adoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have the one comment around virtualization, I think this looks like a good step and intro to disaster recovery especially since I know the plan is the follow up with more details for each scenario.
I removed the "Advantages" placeholders because we currently don't have any information to provide there. |
Hi @maximiliankolb, you gave this an ack a while ago but some things have changed since then. Do you want to re-review? |
//The IP address can change. | ||
//==== | ||
|
||
Virtualizing your {ProjectServer}:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Virtualizing your {ProjectServer}:: | |
.Virtualizing your {ProjectServer} |
I would personally prefer informal headings for the plan names but it isn't blocking your PR.
What changes are you introducing?
I'm adding a list of recommended disaster recovery plans. Each DR plan description follows the same template to make it easier to compare them and help users decide which one to choose.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
N/A
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
As a next step, I'd like to provide more detailed instructions for each of the DR methods. Ideally with three procedures for each: 1. Steps to prepare, 2. Steps to test, 3. Steps to recover.
Checklists
Please cherry-pick my commits into: