Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename concept managing Foreman with Ansible #3581

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Rename concept managing Foreman with Ansible #3581

merged 1 commit into from
Jan 20, 2025
+15 −15

Conversation

maximiliankolb
Copy link
Contributor

What changes are you introducing?

Rename the concept to drop "Collections" because that's "just a silly implementationd detail".

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

fixes 3576

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

  • I also renamed the file/anchor to match the title more closely
  • I copied the section about configuring hosts using Ansible + automating Foreman using Ansible

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@maximiliankolb maximiliankolb linked an issue Jan 17, 2025 that may be closed by this pull request
Rename "Managing Project with Ansible Collections" to "Managing Project with Ansible" #3576
Closed
@maximiliankolb maximiliankolb mentioned this pull request Jan 17, 2025
Closed
@github-actions GitHub Actions
Copy link

The PR preview for 988ab4b is available at theforeman-foreman-documentation-preview-pr-3581.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@asteflova
Copy link
Member

"silly implementation detail" should cover tech review.

@asteflova asteflova added tech review done No issues from the technical perspective style review done No issues from docs style/grammar perspective labels Jan 17, 2025
@maximiliankolb maximiliankolb merged commit 3ce6aee into theforeman:master Jan 20, 2025
9 checks passed
@maximiliankolb maximiliankolb deleted the fix_3576_rename_guide branch January 20, 2025 11:27
maximiliankolb added a commit that referenced this pull request Jan 20, 2025
@maximiliankolb
Rename concept managing Foreman with Ansible (#3581)
ddfc4bc 
fixes 3576

(cherry picked from commit 3ce6aee)
maximiliankolb added a commit that referenced this pull request Jan 20, 2025
@maximiliankolb
Rename concept managing Foreman with Ansible (#3581)
e55d3c1 
fixes 3576

(cherry picked from commit 3ce6aee)
@maximiliankolb
Copy link
Contributor Author

Merged to "master" and cherry-picked:
329569b..ddfc4bc 3.13 -> 3.13
0d47aeb..e55d3c1 3.12 -> 3.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteflova asteflova asteflova approved these changes

Assignees
No one assigned
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename "Managing Project with Ansible Collections" to "Managing Project with Ansible"
2 participants
@maximiliankolb @asteflova