Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP(S) proxy username and password Setting #3635

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Add HTTP(S) proxy username and password Setting #3635

merged 1 commit into from
Feb 5, 2025

Conversation

lfu
Copy link
Contributor

@lfu lfu commented Feb 3, 2025

What changes are you introducing?

  • Add HTTP(S) proxy username setting
  • Add HTTP(S) proxy password setting

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

theforeman/foreman#10432

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Feb 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025 •
edited
Loading

The PR preview for b9fe65d is available at theforeman-foreman-documentation-preview-pr-3635.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

Lennonka
Lennonka reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion on the wording of descriptions if you agree

guides/common/modules/ref_general-settings-information.adoc Outdated Show resolved Hide resolved
@lfu lfu force-pushed the http_proxy_password branch from d7f5d12 to b9fe65d Compare February 4, 2025 14:57
@Lennonka Lennonka added style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective and removed Needs style review Requires a review from docs style/grammar perspective Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Feb 5, 2025
@Lennonka Lennonka merged commit 9a795c2 into theforeman:master Feb 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lennonka Lennonka Lennonka approved these changes

Assignees
No one assigned
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lfu @Lennonka