Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add el10 mock config #11631

Open
wants to merge 1 commit into
base: rpm/develop
Choose a base branch
from
Open

add el10 mock config #11631

wants to merge 1 commit into from

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jan 16, 2025

No description provided.

@evgeni evgeni requested a review from a team as a code owner January 16, 2025 10:04
Comment on lines +16 to +18
#config_opts['module_setup_commands'] = [
# ('enable', 'foreman-devel:el10'),
#]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't exist for EL10 yet

Comment on lines +75 to +89
#[foreman]
#name=foreman
#baseurl=https://yum.theforeman.org/nightly/el10/x86_64/
#
#[foreman-plugins]
#name=foreman-plugins
#baseurl=https://yum.theforeman.org/plugins/nightly/el10/x86_64/
#
#[katello]
#name=katello
#baseurl=https://yum.theforeman.org/katello/nightly/katello/el10/x86_64/
#
#[puppet-8]
#name=puppet-8
#baseurl=https://yum.puppetlabs.com/puppet8/el/10/x86_64/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't exist for EL10 yet

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about using more of the approach taken with includes. For example, /etc/mock/centos-stream+epel-10-x86_64.cfg is

config_opts["koji_primary_repo"] = "epel"
include('templates/centos-stream-10.tpl')
include('templates/epel-10.tpl')

config_opts['root'] = 'centos-stream+epel-10-x86_64'
config_opts['description'] = 'CentOS Stream 10 + EPEL'
config_opts['target_arch'] = 'x86_64'
config_opts['legal_host_arches'] = ('x86_64',)

It does rely on mock configs being up to date, but I think that's safe to rely on. Looking at /etc/mock/templates/epel-10.tpl we can then use config_opts['dnf.conf'] += """ to add our own repos.

@evgeni
Copy link
Member Author

evgeni commented Jan 16, 2025

the templates is where I got the stuff from yeah…

@ekohl
Copy link
Member

ekohl commented Jan 16, 2025

Let me phrase it different: I'd like to minimize our mock configs. Perhaps even split it so we can layer them, just like in real life. So a config for client bits (which is probably plain EL10), a config for base foreman + plugins, and katello.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants