disable pulpcore analytics #65
Conversation
archanaserver
force-pushed
the
disable-pulpcore-analytics
branch
from
0c691b8 to
88b37f7
Compare
|
Can anyone help with, how can I ensure here that the setting I'm trying to make is updated in our |
roles/pulp/templates/settings.py.j2
Outdated
| @@ -17,3 +17,4 @@ DATABASES = { | |||
| AUTHENTICATION_BACKENDS=['pulpcore.app.authentication.PulpNoCreateRemoteUserBackend'] | |||
| REMOTE_USER_ENVIRON_NAME="HTTP_REMOTE_USER" | |||
| REST_FRAMEWORK__DEFAULT_AUTHENTICATION_CLASSES=('rest_framework.authentication.SessionAuthentication', 'pulpcore.app.authentication.PulpRemoteUserAuthentication') | |||
| ENABLE_ANALYTICS = {{ pulp_enable_analytics | default(false) }} | |||
There was a problem hiding this comment.
Without looking too closely, I think this ends up as true or false but Python uses True and False
There was a problem hiding this comment.
I've updated it to explicitly cast the value as a boolean using | bool, ensuring it correctly translates to True or False.
|
If you use |
archanaserver
force-pushed
the
disable-pulpcore-analytics
branch
from
f487b46 to
435d243
Compare
|
@ekohl @ehelms can you help me understand what is this ansible lint failure here? |
|
Trying to fix that over here -- #74 |
archanaserver
force-pushed
the
disable-pulpcore-analytics
branch
from
435d243 to
f30d2fc
Compare
| @@ -17,3 +17,4 @@ DATABASES = { | |||
| AUTHENTICATION_BACKENDS=['pulpcore.app.authentication.PulpNoCreateRemoteUserBackend'] | |||
| REMOTE_USER_ENVIRON_NAME="HTTP_REMOTE_USER" | |||
| REST_FRAMEWORK__DEFAULT_AUTHENTICATION_CLASSES=('rest_framework.authentication.SessionAuthentication', 'pulpcore.app.authentication.PulpRemoteUserAuthentication') | |||
| ENABLE_ANALYTICS = {{ pulp_enable_analytics | default(false) | bool | ternary('True', 'False') }} | |||
There was a problem hiding this comment.
I think this should be ANALYTICS - https://github.com/theforeman/puppet-pulpcore/blob/master/templates/settings.py.erb#L17
|
Also, I am not sure why the tests are failing right now. This appears unrelated to your change. |
Fixes #58