update URL of local advisor engine as it is deployed by the installer

[evgeni]

• don't set legacy insights ca when local advisor engine is used
• update URL of local advisor engine as it is deployed by the installer

[ekohl]

I'm trying to figure out what's going on in lib/foreman_rh_cloud.rb and I think it's extremely complex. It's sort of reinventing the settings system we already have in place. Also, we have a generic proxy system and it doesn't appear to be reusing that.

For example:

foreman_rh_cloud/lib/foreman_rh_cloud.rb

Lines 65 to 82 in 50e24b6

	def self.cdn_proxy(logger: Foreman::Logging.logger('app'))
	proxy_config = SETTINGS[:katello][:cdn_proxy]
	return nil unless proxy_config
	uri = URI('')
	uri.host = proxy_config[:host]
	uri.port = proxy_config[:port]
	uri.scheme = proxy_config[:scheme] || 'http'
	if proxy_config[:user]
	uri.user = CGI.escape(proxy_config[:user])
	uri.password = CGI.escape(proxy_config[:password])
	end
	uri.to_s
	rescue URI::Error => e
	logger.warn("cdn_proxy parsing failed: #{e}")
	nil
	end

In Katello/katello@d593923 the last traces of this were removed. #944 gets rid of that at least.

[chris1984]

Looks fine to me, @parthaa can you have a look as well?

[parthaa]

LGTM