Fixes #38085 - Cap the number of Puma workers at 100 #1197
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Dec 11, 2024
ekohl
force-pushed
the
cap-puma-workers
branch
from
a069246 to
53e9176
Compare
bastelfreak
approved these changes
Dec 11, 2024
Users can easily run out of PostgreSQL connections on large deployments. This provides a ceiling to the automatically calculated Puma workers because it's unclear if that really provides performance benefits while it can break deployments. Not noticable here, but foreman-installer defaults to max 500 PostgreSQL connections and has tuning options that to increase it to 1000. Ideally it would be smarter, but it's really hard to account for all possible conditions.
ekohl
force-pushed
the
cap-puma-workers
branch
from
53e9176 to
8faafca
Compare
|
I really should have tested this locally, but third time is the charm. |
11 tasks
ehelms
reviewed
Dec 12, 2024
ehelms
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can easily run out of PostgreSQL connections on large deployments. This provides a ceiling to the automatically calculated Puma workers because it's unclear if that really provides performance benefits while it can break deployments.
Not noticable here, but foreman-installer defaults to max 500 PostgreSQL connections and has tuning options that to increase it to 1000.
Ideally it would be smarter, but it's really hard to account for all possible conditions.