-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameter outofsync_interval #1202
Open
WoutResseler
wants to merge
13
commits into
theforeman:master
Choose a base branch
from
WoutResseler:out-of-sync-inteval-config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add parameter outofsync_interval #1202
WoutResseler
wants to merge
13
commits into
theforeman:master
from
WoutResseler:out-of-sync-inteval-config
+77
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds oidc config params
Fix optional params to be undef
Do not follow keycloak config by default
…-config Add parameter outofsync_interval
This is IMHO a duplicate of #1007. It's true you can't set it via Hiera and it's using the CLI so it won't end up as a read-only setting, but I'd prefer to avoid adding all settings as parameters on |
…-config Move the outofsync_interval config to foreman::settings
Fix syntax errors
WoutResseler
force-pushed
the
out-of-sync-inteval-config
branch
from
January 17, 2025 10:38
c92e5d3
to
4843760
Compare
@ekohl I moved the configuration as requested to foreman::settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the parameter
outofsync_interval
to make it configurable from puppet and over writable from possible hiera config