Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add trivial acceptance tests #5

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jan 9, 2025

No description provided.

spec/setup_acceptance_node.pp Outdated Show resolved Hide resolved
.fixtures.yml Show resolved Hide resolved
@@ -0,0 +1,64 @@
# https://github.com/mizzy/serverspec/pull/611 was rejected so adding it here.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really should be in voxpupuli-acceptance

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being added here -- voxpupuli/voxpupuli-acceptance#89

Comment on lines +11 to +12
Image=registry.access.redhat.com/ubi9/python-312
Exec=python /usr/local/bin/python-https-server
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is obviously still a fake, but a much more elaborate one :D

We should be able to replace this with the "real" deal once a build is available.

Comment on lines 25 to 26
# curl on EL8 is too old to support --write-out %stderr
command = "/opt/puppetlabs/puppet/bin/curl --silent --write-out '%{stderr}Response-Code: %{response_code}\\n' '#{@name}'"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can use plain EL-curl now?

@ehelms
Copy link
Member

ehelms commented Jan 15, 2025

Looking good to me -- what do you need to move it out of draft?

@evgeni
Copy link
Member Author

evgeni commented Jan 15, 2025

Looking good to me -- what do you need to move it out of draft?

need nothing, I was waiting whether we can get

But nothing should be preventing us merging as is and then cleaning up later.

@evgeni evgeni marked this pull request as ready for review January 15, 2025 15:12
@ehelms
Copy link
Member

ehelms commented Jan 15, 2025

I'd rather have some more testing that get's cleaned up than sit on it and not have it.

@ehelms ehelms merged commit 7119d74 into theforeman:master Jan 15, 2025
8 checks passed
@evgeni evgeni deleted the acceptance branch January 15, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants