-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add trivial acceptance tests #5
Conversation
@@ -0,0 +1,64 @@ | |||
# https://github.com/mizzy/serverspec/pull/611 was rejected so adding it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really should be in voxpupuli-acceptance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being added here -- voxpupuli/voxpupuli-acceptance#89
Image=registry.access.redhat.com/ubi9/python-312 | ||
Exec=python /usr/local/bin/python-https-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is obviously still a fake, but a much more elaborate one :D
We should be able to replace this with the "real" deal once a build is available.
# curl on EL8 is too old to support --write-out %stderr | ||
command = "/opt/puppetlabs/puppet/bin/curl --silent --write-out '%{stderr}Response-Code: %{response_code}\\n' '#{@name}'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can use plain EL-curl now?
Looking good to me -- what do you need to move it out of draft? |
need nothing, I was waiting whether we can get
But nothing should be preventing us merging as is and then cleaning up later. |
I'd rather have some more testing that get's cleaned up than sit on it and not have it. |
No description provided.