Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit/#641: add fact sheet and logo #645

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

Erin-Cecele
Copy link
Collaborator

Thank you for contributing to the Quire Documentation & Website! Please complete the form below to submit your pull request for review.

For the Title of this pull request, please use the format "Type/Issue-#: Brief description." For Type, the options are Edit, Add, Translate. Issue-# is only needed if this pull request addresses an existing issue.

Checklist

Please put an X within the brackets that apply [X].

  • I have read the CONTRIBUTING.md file.

  • I have made my changes in a new branch and not directly in the main branch

  • I am requesting feedback on a draft pull request

Is this pull request related to an open issue? If so, what is the issue number?

#641

Please describe the goal of this pull request and the changes that were made.

Update fact sheet on home page

Additional Comments

@geealbers I also noticed that the logo on the website appears to be the old one. I tried to update to the new logo in this PR by replacing what I found in the static/img/ folder but I'm not seeing these changes reflected on the website. Please help or advise.

@Erin-Cecele Erin-Cecele requested a review from geealbers January 27, 2023 22:55
Copy link
Member

@geealbers geealbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logo file you uploaded is a little smaller than the original. Do you know where this is being used? Will the size difference have a negative impact on the layout anywhere?

@Erin-Cecele
Copy link
Collaborator Author

@geealbers I was trying to update the logos at the top left corner and the very bottom of the page as they are the old logo.

Adding this new image should be reflected at the bottom of the homepage, but for some reason, it's not. Also not sure what to do about the different size. This is the quire_logo_positive_small_RGB.png that Jeffrey gave us.

Screen Shot 2023-01-27 at 3 47 20 PM

I also can't figure out how the black logo at the top left is being pulled in. I can't find anything with the id homepage-banner-image.

Screen Shot 2023-01-27 at 3 53 40 PM

@geealbers
Copy link
Member

@Erin-Cecele when I preview this PR, I'm seeing the new logo (with the TM in the lower right instead of the upper right) in both the top left corner of the site, and at the home page as expected. Can you try again, maybe with a hard refresh to clear your browser cache?

@Erin-Cecele
Copy link
Collaborator Author

Oh my god! The hard refresh worked ::facepalm:: Well, looks like the fact sheet was still a bit outdated. So, it's been updated!

@Erin-Cecele Erin-Cecele merged commit ab27a36 into main Jan 17, 2024
@Erin-Cecele Erin-Cecele deleted the edit/add-fact-sheet-logo branch January 17, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants