Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DERCBOT-1309] Enable Annotation and Issue Tracking for Bot Responses #1824

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

[DERCBOT-1309] Enable Annotation and Issue Tracking for Bot Responses #1824

wants to merge 21 commits into from

Conversation

scezen
Copy link
Contributor

@scezen scezen commented Jan 14, 2025

No description provided.

@scezen scezen marked this pull request as draft January 14, 2025 08:53
@Benvii Benvii mentioned this pull request Jan 15, 2025
Closed
@scezen scezen marked this pull request as ready for review January 29, 2025 13:42
assouktim
assouktim requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@assouktim assouktim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the code you've added, it's really a great effort behind it.
There are still many improvements to be made, i'll let you take them into account.

bot/admin/server/src/main/kotlin/verticle/DialogVerticle.kt Show resolved Hide resolved
bot/admin/server/src/main/kotlin/BotAdminService.kt Show resolved Hide resolved
bot/admin/server/src/main/kotlin/BotAdminService.kt Show resolved Hide resolved
bot/admin/server/src/main/kotlin/BotAdminService.kt Show resolved Hide resolved
bot/storage-mongo/src/main/kotlin/UserTimelineMongoDAO.kt Show resolved Hide resolved
bot/engine/src/main/kotlin/admin/annotation/BotAnnotation.kt Show resolved Hide resolved
bot/engine/src/main/kotlin/admin/annotation/BotAnnotationEvent.kt Show resolved Hide resolved
bot/admin/server/src/main/kotlin/BotAdminService.kt Show resolved Hide resolved
bot/admin/server/src/main/kotlin/verticle/DialogVerticle.kt Show resolved Hide resolved
bot/engine/src/main/kotlin/admin/annotation/BotAnnotationDTO.kt
val reason: BotAnnotationReasonType? = null,
val description: String,
val groundTruth: String? = null,
val events: List<BotAnnotationEventDTO> = emptyList()
Copy link
Contributor

@assouktim assouktim Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we'll need these events here, as I can see that this class is only used to create an annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assouktim assouktim assouktim requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scezen @assouktim