Add some more attributes test #944
Conversation
| @@ -43,7 +43,7 @@ final class RegexHelper | |||
| public const PARTIAL_TAGNAME = '[a-z][a-z0-9-]*'; | |||
| public const PARTIAL_BLOCKTAGNAME = '(?:address|article|aside|base|basefont|blockquote|body|caption|center|col|colgroup|dd|details|dialog|dir|div|dl|dt|fieldset|figcaption|figure|footer|form|frame|frameset|h1|head|header|hr|html|iframe|legend|li|link|main|menu|menuitem|nav|noframes|ol|optgroup|option|p|param|section|source|summary|table|tbody|td|tfoot|th|thead|title|tr|track|ul)'; | |||
| public const PARTIAL_ATTRIBUTENAME = '[a-z_:][a-z0-9:._-]*'; | |||
| public const PARTIAL_UNQUOTEDVALUE = '[^"\'=<>`\x00-\x20]+'; | |||
| public const PARTIAL_UNQUOTEDVALUE = '[^"\'=<>}`\x00-\x20]+'; | |||
There was a problem hiding this comment.
This constant is also used to parse HTML and according to the spec a } is allowed in unquoted values:
Attributes are placed inside the start tag, and consist of a name and a value, separated by an "=" character. The attribute value can remain unquoted if it doesn't contain ASCII whitespace or any of " ' ` = < or >. Otherwise, it has to be quoted using either single or double quotes. The value, along with the "=" character, can be omitted altogether if the value is the empty string.
So we'll need to find another way to fix the issue you found.
|
Thanks for adding these tests! They were super helpful in pinpointing the cause of this issue. I'm going to merge an alternate solution (that includes your new tests) in #945. |
Related to #943, here's a few more test. One of them also fails at the moment because there seems to be a bug.