-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage for delegated hash bins target download #1910
Add test coverage for delegated hash bins target download #1910
Conversation
Pull Request Test Coverage Report for Build 2027942163
💛 - Coveralls |
8247de1
to
b32d345
Compare
This change adds tests coverage for `path_hash_prefixes` and verifies that role names matching specific prefixed successfully find and download the corresponding metadata files and do not succeed to find existing, but non-matching files Signed-off-by: Ivana Atanasova <[email protected]>
b32d345
to
02afa59
Compare
I've not given this the review it needed, sorry... This vaguely looks like we could do better but I can't immediately see the better way: did you consider having the same test setup as in the existing downloads test
This would not make the current test much shorter but it might mean that adding a new test case would be maybe 2 lines instead of 40 lines of test data that it is now? |
"delegate_1.ext", | ||
), | ||
], | ||
visited_order=["f8-ff", "20-27"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed you are not using visited_order
anywhere in your test.
Is this superseded by #2031? Should we think about deprecating |
I think so. I wouldn't object to a tight client test specifically for hashed bins but I don't think it's super important, and this PR is 80 lines of test code for very limited (new) test functionality. |
This change adds tests coverage for
path_hash_prefixes
andverifies that role names matching specific prefixed successfully
find and download the corresponding metadata files and do not
succeed to find existing, but non-matching files
Fixes #1639
Follow-up of #1808