Fix lint warnings, Add some lint rulesets #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove lint rules from ignore: these are now ignored by default * Add new rulesets to lint (DTZ, FA, PIE, RET, SIM): See https://docs.astral.sh/ruff/rules/ for details * Fix minor issues found by the rulesets * datetime.now() is deprecated * start argument in range() calls is not required * elif not required after return * pass not required Signed-off-by: Jussi Kukkonen <[email protected]>
loosebazooka
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal here is to silence this warning:
This meant just removing them from lint.ignore list.
While I was looking at the lint config, I did add a few lint rulesets that I use elsewhere too (see https://docs.astral.sh/ruff/rules/ for details) . This meant a few minor code tweaks.