Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to "Requesting changes to person data" - October 2023 #359

Merged
merged 2 commits into from
Oct 22, 2023

Conversation

c-goodyear
Copy link
Contributor

As discussed among WRT in an email thread and shared doc.

As discussed among WRT in an email thread and shared doc.
@c-goodyear c-goodyear requested a review from a team as a code owner October 15, 2023 17:44
nsilvestri
nsilvestri previously approved these changes Oct 15, 2023
Copy link
Member

@nsilvestri nsilvestri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dmint789 dmint789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes

edudoc/delegate-crash-course/delegate_crash_course.md Outdated Show resolved Hide resolved
edudoc/delegate-crash-course/delegate_crash_course.md Outdated Show resolved Hide resolved
Fixes Deni's comments
@dmint789
Copy link
Member

Are you guys sure it's a good idea to link to specific people's profiles? I dunno if I'd want to have my profile having attention drawn to it.

@DanielEgdal
Copy link
Member

DanielEgdal commented Oct 21, 2023

Seems completely fine to me, as this is just showing what is already public information. As Callum said, it is valuable to have an example. Additionally, the person in the example even has a wiki page so it is not like it is a person unknown to public exposure.

Copy link
Member

@dmint789 dmint789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dmint789 dmint789 merged commit 2662d6a into thewca:master Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants