Fix weird but necessary edge case in serializable_opts monkey-patch #10675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
force-pushed
the
fixup/merge-serialization-opts
branch
from
ef57a10 to
347d86c
Compare
|
Nevermind, found a simpler solution. Still don't think I need a review as long as CI says OK |
gregorbg
force-pushed
the
fixup/merge-serialization-opts
branch
from
347d86c to
e2b25b2
Compare
gregorbg
force-pushed
the
fixup/merge-serialization-opts
branch
from
e2b25b2 to
8940316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #10575 to cover an edge-case where nested options are passed down as hash instead of array.
As noted in that other PR, it is a horrible, horrible idea to squeeze-merge two different ORM models together, and it's an even worse idea to pass around serialization options from one to the other. But our APIs have grown to expect this behavior, so we cannot remove this serialization nightmare without breaking API contracts.
I don't expect anybody to review or even understand this patch, I really just need to see whether the CI passes.