Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving back to single tab #42

Closed
thibautjombart opened this issue Mar 29, 2020 · 3 comments
Closed

Moving back to single tab #42

thibautjombart opened this issue Mar 29, 2020 · 3 comments
Assignees
Labels
design enhancement New feature or request priority This needs to get done first

Comments

@thibautjombart
Copy link
Owner

Several comments on the app e.g. #35 suggested forecasts for the 2 types of hospitalisation could be on the same page. This is down to personnal preferences to a large extent, but leaving space for a discussion here.

Pro 2 tabs

  • clearer outputs
  • ability to model both separately
  • ability to put both results on the same page if needed

Pro 1 tab

  • common growth parameters and numbers of simulations make sense
@samclifford
Copy link
Collaborator

I suggest making the doubling time common to both ICU and non-ICU beds by reusing the same input box. Otherwise when you flick to the Overall tab and have two different doubling times you get inconsistent results.

@thibautjombart
Copy link
Owner Author

I agree. It seems we agree on reverting back to a single tab. @pearsonca agreed to take the lead on this. Renaming issue accordingly.

@thibautjombart thibautjombart added enhancement New feature or request priority This needs to get done first labels Apr 1, 2020
@thibautjombart thibautjombart changed the title 2 tabs vs 1 Moving back to single tab Apr 1, 2020
@thibautjombart
Copy link
Owner Author

Closed via 0e32999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement New feature or request priority This needs to get done first
Projects
None yet
Development

No branches or pull requests

3 participants