[SDK] Feature: add flag for skipping default ecosystem info fetch #6052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ced76d9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@alecananian is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an ecosystem has account abstraction settings turned on in the Thirdweb dashboard, there's currently no way through the SDK to allow users to log into their ecosystem wallets - they'll always be wrapped into their smart wallets for chains that use an account factory strategy (e.g., Arbitrum Sepolia chain ID 421614). We have a need to allow ecosystem wallet access for transferring assets that may have been mistakenly sent to that address.
PR-Codex overview
This PR introduces an optional flag for ecosystem wallet creation that allows users to skip fetching default ecosystem information. This enhances flexibility in wallet creation by providing developers with more control over the data retrieval process.
Detailed summary
skipEcosystemInfoflag intypes.tsto skip fetching ecosystem info.ecosystem.tsto passskipEcosystemInfoto wallet creation options.in-app-core.tsto conditionally fetch ecosystem info based onskipEcosystemInfo.