Stop function final reviwe #109
Conversation
pradeepkumara
temporarily deployed
to
static-site
GitHub Actions
Inactive
|
There was a problem hiding this comment.
Hey @pradeepkumara! This is a decent attempt, but it needs a lot of fixes before it can be considered complete; right now it doesn't actually work. Have another check over the code and see if you can patch it up based on the suggestions 😃
| <button type="button" id="stopProgram"> | ||
| <i class="bi bi-stop-fill"></i> | ||
| <span>Stop</span> | ||
| </button> | ||
| <button type="button" id="collapsedStopProgram" title="Stop Program"> | ||
| <i class="bi bi-stop-fill">Terminate</i> | ||
| </button> | ||
|
|
||
| <button type="button" id="stopProgram" style="display:none"><i class="bi bi-pause-fill">Pause</i></button> |
There was a problem hiding this comment.
I'm not sure this is working as intended - we end up with two stop buttons by accident, and the pause button is hidden since it has the same ID stopProgram:
The collapsedStopProgram button should only be visible when the interface is collapsed, and the normal pause button should still be visible.
Maybe something like this?
There was a problem hiding this comment.
thank you for the feedback, I will change this.
| * Checks if a program is currently running | ||
| * @returns {boolean} - True if a program is running, false otherwise | ||
| */ | ||
| function isProgramRunning() { | ||
| // Replace this with the actual logic to check program state | ||
| return runtimeManager.isRunning(); | ||
| } | ||
|
|
||
| /** | ||
| * Displays a notification to the user | ||
| * @param {string} message - The message to display | ||
| * @param {string} type - The type of the notification ("info", "warning", "error") | ||
| */ | ||
| function showNotification(message, type) { | ||
| // Replace this with your actual notification logic | ||
| console.log(`[${type.toUpperCase()}] ${message}`); | ||
| } |
There was a problem hiding this comment.
These don't make sense, I'm assuming AI generated?
| * Terminates the currently running program | ||
| */ | ||
| function terminateProgram() { | ||
| try { | ||
| // Logic to terminate the running process | ||
| runtimeManager.terminate(); | ||
| updateRuntimeButtons(false); // Disable runtime buttons after stopping | ||
| } catch (error) { | ||
| throw new Error("Program termination failed: " + error.message); | ||
| } | ||
| } |
There was a problem hiding this comment.
Again, AI code that shouldn't be in here.
| terminateProgram(); | ||
| }); | ||
|
|
||
| document.getElementById("collapsedStopProgram").addEventListener("click", () => { | ||
| terminateProgram(); | ||
| }); | ||
|
|
||
| // Attach event listeners for Stop buttons | ||
| initializeEventListeners(); | ||
|
|
||
| function initializeEventListeners() { | ||
| const stopButton = document.getElementById("stopProgram"); | ||
| const collapsedStopButton = document.getElementById("collapsedStopProgram"); | ||
|
|
||
| stopButton.addEventListener("click", handleStopProgram); | ||
| collapsedStopButton.addEventListener("click", handleStopProgram); | ||
| } | ||
|
|
||
| /** | ||
| * Handles the stop button click event | ||
| */ | ||
| function handleStopProgram() { | ||
| if (!isProgramRunning()) { | ||
| showNotification("No program is currently running.", "warning"); | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| terminateProgram(); | ||
| showNotification("Program stopped successfully.", "info"); | ||
| } catch (error) { | ||
| console.error("Error while stopping the program:", error); | ||
| showNotification("Failed to stop the program. Please try again.", "error"); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Terminates the currently running program | ||
| */ | ||
| function terminateProgram() { | ||
| try { | ||
| // Logic to terminate the running process | ||
| runtimeManager.terminate(); | ||
| updateRuntimeButtons(false); // Disable runtime buttons after stopping | ||
| } catch (error) { | ||
| throw new Error("Program termination failed: " + error.message); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Updates the runtime control buttons based on the program state | ||
| * @param {boolean} isRunning - Whether the program is currently running | ||
| */ | ||
| function updateRuntimeButtons(isRunning) { | ||
| toggleButtonState("stopProgram", isRunning); | ||
| toggleButtonState("collapsedStopProgram", isRunning); | ||
| } |
There was a problem hiding this comment.
This should all be in editorMain.js - there's a lot of framework code already there to help. Have a look in the functions setupIDEButtonEvents and updateButtons 😃
Description
I have changed the stop funciton according to the specification given in the task
Fixes # (issue)
Type of change
Please delete options that are not relevant.
expected)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
Testing Checklist
Checklist