Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only change read status if in the same tab #210

Closed
wants to merge 3 commits into from
Closed

Only change read status if in the same tab #210

wants to merge 3 commits into from

Conversation

Pythonix
Copy link
Contributor

@Pythonix Pythonix commented May 1, 2017

I changed the code, so that the read status of the message is only changed if the tab with the chat opened is the active browser window.

@CLAassistant
Copy link

CLAassistant commented May 1, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Pythonix
❌ Raphael Husistein


Raphael Husistein seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dbrgn
Copy link
Contributor

dbrgn commented May 2, 2017

Hi

Thanks for your contribution! I assume that this intends to fix #17.

We already have a pull request open against one of the libraries we use to detect whether a message is in the viewport or not: thenikso/angular-inview#122 It has some advantages over your solutions, for example that it doesn't require setting timeouts and that the visibilityState attribute is also considered.

Since that pull request hasn't been merged for almost two months now, I'll vendorize the angular-inview library with the fix until something happens upstream. I'll close your PR, but will create another PR soon with a fix for #17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants