Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up image permissions for Android #1657

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR removes the following permissions from AndroidManifest:

  • READ_EXTERNAL_STORAGE
  • READ_MEDIA_IMAGES
  • READ_MEDIA_VIDEO

The main reason for this is to comply with some Google Play Store requirements. Here is an article containing more information about this: https://support.google.com/googleplay/android-developer/answer/14115180

As a result, I've also updated the way permissions are requested when saving images in the image viewer. We no longer use permission_handler, but rather handle permissions through the gal package. Additionally, I've removed the device_info_plus dependency since it looks like it's no longer needed.

All in all, this reduces some of our permission logic, and cleans up some of our dependencies!

@micahmo I did some testing on Android emulators (specifically, API versions 35 and 29), so it should be working as expected. However, please let me know if you encounter any issues saving or uploading images!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll let you know if I run into any issues with these changes!

@hjiangsu hjiangsu merged commit 9d850d1 into develop Jan 14, 2025
1 check passed
@hjiangsu hjiangsu deleted the feature/image-permission-improvements branch January 14, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants