Clean up image permissions for Android #1657
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR removes the following permissions from
AndroidManifest
:READ_EXTERNAL_STORAGE
READ_MEDIA_IMAGES
READ_MEDIA_VIDEO
The main reason for this is to comply with some Google Play Store requirements. Here is an article containing more information about this: https://support.google.com/googleplay/android-developer/answer/14115180
As a result, I've also updated the way permissions are requested when saving images in the image viewer. We no longer use
permission_handler
, but rather handle permissions through thegal
package. Additionally, I've removed thedevice_info_plus
dependency since it looks like it's no longer needed.All in all, this reduces some of our permission logic, and cleans up some of our dependencies!
@micahmo I did some testing on Android emulators (specifically, API versions 35 and 29), so it should be working as expected. However, please let me know if you encounter any issues saving or uploading images!
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Checklist
semanticLabel
s where applicable for accessibility?