-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cache #6655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these tests are only running on the JVM we can use spaces in method names for better readability.
For assertions newer code typically uses Truth (e.g. assertThat(…).isEqualTo(…)
).
Even if Truth works with Kotlin, it is not optimized for Kotlin. What about selecting a Kotlin assertion library that also has support for Kotlin Multiplatform? This could help to select one: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the duplicate test LGTM 👍
For the contact refactoring, I need to use a different cache and extracted a general purpose solution. It provides a
InMemoryCache
,ExpiringCache
andSynchronizedCache
to fit several needs.