Add Cyberstorm endpoint for disconnecting linked accounts #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 18, 2024
|
This PR is missing tests. @MythicManiac Any suggestions on how to test the social auth objects, cause there doesn't seem to be any easy way to create them? |
Oksamies
force-pushed
the
12-11-Add_DisbandTeamAPIView
branch
from
a0232ab to
2bff326
Compare
Oksamies
force-pushed
the
07-18-Add_Cyberstorm_endpoint_for_disconnecting_linked_accounts
branch
from
9935006 to
ed9f73e
Compare
Oksamies
force-pushed
the
12-11-Add_DisbandTeamAPIView
branch
from
2bff326 to
86f7377
Compare
Oksamies
force-pushed
the
07-18-Add_Cyberstorm_endpoint_for_disconnecting_linked_accounts
branch
from
ed9f73e to
dd1db0a
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -6,9 +6,43 @@ | |||
| from thunderstore.frontend.views import SettingsViewMixin | |||
|
|
|||
|
|
|||
| class LinkedAccountDisconnectExecption(Exception): | |||
There was a problem hiding this comment.
The class name LinkedAccountDisconnectExecption contains a typo - it should be LinkedAccountDisconnectException. This appears to be a simple misspelling of the word "Exception".
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
|
|
||
| class CyberstormException(APIException): | ||
| status_code = status.HTTP_400_BAD_REQUEST | ||
| default_detail = _("Issue occured when trying to process action") |
There was a problem hiding this comment.
The word occured in the error message is misspelled - it should be occurred. The full message should read: "Issue occurred when trying to process action"
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.