Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(navbar): Floating navbar #13

Merged
merged 1 commit into from
Apr 17, 2024
Merged

feat(navbar): Floating navbar #13

merged 1 commit into from
Apr 17, 2024

Conversation

anishshobithps
Copy link
Member

No description provided.

@anishshobithps anishshobithps self-assigned this Apr 17, 2024
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 3:59am

@anishshobithps anishshobithps linked an issue Apr 17, 2024 that may be closed by this pull request
1 task
@anishshobithps
Copy link
Member Author

cc @rabilrbl @joywin2003 , any changes let me know

@rabilrbl
Copy link
Member

rabilrbl commented Apr 17, 2024

@anishshobithps You happy with the height? I feel it's slightly big on my 14inch

@Vyshnav001
Copy link
Contributor

@anishshobithps i think it will be better if it hides when it scroll to the bottom and reveals when it scroll to the top

Copy link
Member

@rabilrbl rabilrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishshobithps
Copy link
Member Author

ill be better if it hides when it scroll to the bottom and reveals when it scroll to the top

True, @Vyshnav001 could you make a issue for the same ? I'll see to it in the evening in a different PR.

@anishshobithps anishshobithps removed the request for review from joywin2003 April 17, 2024 06:37
@anishshobithps anishshobithps merged commit 3ce11a0 into main Apr 17, 2024
3 checks passed
@anishshobithps anishshobithps deleted the navbar branch April 17, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

floating navbar
3 participants