Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events Page #15

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Events Page #15

merged 6 commits into from
Apr 18, 2024

Conversation

rabilrbl
Copy link
Member

resolves #1

@vercel Vercel
Copy link

vercel bot commented Apr 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 9:04am

anishshobithps
anishshobithps reviewed Apr 17, 2024
View reviewed changes
src/app/api/gallery/route.ts
@@ -5,7 +5,7 @@ export async function GET() {
const imageDirectory = path.join(process.cwd(), "public", "gallery");
const imageFiles = fs.readdirSync(imageDirectory);
const images = imageFiles.map((file: string, i: number) => ({
alt: `Image ${i}`,
alt: `Imagae ${i}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be changed ?

anishshobithps
anishshobithps requested changes Apr 17, 2024
View reviewed changes
src/components/ui/timechart.tsx Outdated
@@ -1,4 +1,5 @@
import React from "react";
import EventCard from "./EventCard";

const timechart = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we are not using timechart, let's not make it timechart or name it that way, let's give proper name for the same ? Also I would prefer Named exports over default

@anishshobithps
Copy link
Member

@melroydsa there seems to be a issue,

<html>
<body>
<!--StartFragment-->
Failed to compile.
--
15:24:14.161 |  
15:24:14.161 | ./src/components/ui/timechart.tsx:2:8
15:24:14.161 | Type error: Module '"/vercel/path0/src/components/ui/EventCard"' has no default export. Did you mean to use 'import { EventCard } from "/vercel/path0/src/components/ui/EventCard"' instead?
15:24:14.161 |  
15:24:14.161 | 1 \| import React from "react";
15:24:14.161 | > 2 \| import EventCard from "./EventCard";
15:24:14.161 | \|        ^
15:24:14.161 | 3 \|
15:24:14.161 | 4 \| const timechart = () => {
15:24:14.161 | 5 \|   const events = [
15:24:14.205 | Error: Command "npx prisma generate && next build" exited with 1

<!--EndFragment-->
</body>
</html>

@anishshobithps anishshobithps mentioned this pull request Apr 17, 2024
Merged
@anishshobithps
Copy link
Member

I suppose the background beam is heavy, its better if its off, on deployment its lagging for me

@anishshobithps
Copy link
Member

I suppose the background beam is heavy, its better if its off, on deployment its lagging for me

@melroydsa can you remove the background beams ? its lagging

@melroydsa
Copy link
Contributor

Alright

@rabilrbl rabilrbl merged commit 5beada0 into main Apr 18, 2024
2 checks passed
@rabilrbl rabilrbl deleted the eventPage branch April 18, 2024 11:16
@anishshobithps anishshobithps mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anishshobithps anishshobithps anishshobithps approved these changes

Assignees

@melroydsa melroydsa

Labels
priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events page
3 participants
@rabilrbl @anishshobithps @melroydsa