Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : Add Conditional Rendering for Event Prerequisites #42

Merged
merged 22 commits into from
May 2, 2024
Merged

Conversation

Vyshnav001
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 8:09am

@rabilrbl
Copy link
Member

@Vyshnav001 What's the status of this PR?

@Vyshnav001 Vyshnav001 marked this pull request as ready for review April 24, 2024 15:53
@Vyshnav001 Vyshnav001 requested a review from rabilrbl April 24, 2024 15:56
@rabilrbl rabilrbl requested a review from anishshobithps April 24, 2024 15:59
@rabilrbl
Copy link
Member

@Vyshnav001 We are not using this route in website anymore.

@anishshobithps Any plans on enabling per event page?

rabilrbl
rabilrbl previously approved these changes Apr 24, 2024
@Vyshnav001
Copy link
Contributor Author

haa that's why i kept it as draft :)

@Vyshnav001
Copy link
Contributor Author

should i close the PR?

@rabilrbl
Copy link
Member

should i close the PR?

No keep it.

@anishshobithps
Copy link
Member

@Vyshnav001 We are not using this route in website anymore.

@anishshobithps Any plans on enabling per event page?

I don't mind, but I had disabled it, the preview doesn't take me to the per event page, or am I missing something ?

@anishshobithps
Copy link
Member

anishshobithps commented Apr 24, 2024

Also, is every data entered in there ?

@Vyshnav001
Copy link
Contributor Author

Also, is every data entered in there ?

Register now button is there and it is not linked ig
better to don't keep

@Vyshnav001
Copy link
Contributor Author

Vyshnav001 commented Apr 24, 2024

but still that page can be accessed through the url
better to delete that page if we are not using

@rabilrbl
Copy link
Member

rabilrbl commented Apr 25, 2024

@Vyshnav001 Can u please check if styling and css is proper for those pages. Also check mobile view.

Then proceed to use <Link> for event cards.

CC: @anishshobithps

@Vyshnav001
Copy link
Contributor Author

@Vyshnav001 Can u please push these changes? So that we can check.

done
Please let me know if there are any issues or if further improvements are needed

@anishshobithps
Copy link
Member

image

Still looks like this for me, could you try adding mx-auto ?

@Vyshnav001
Copy link
Contributor Author

image

Still looks like this for me, could you try adding mx-auto ?

mx-auto is not working for some reason

@Vyshnav001
Copy link
Contributor Author

@anishshobithps check now

@rabilrbl
Copy link
Member

rabilrbl commented May 1, 2024

@anishshobithps check now

image

@rabilrbl
Copy link
Member

rabilrbl commented May 1, 2024

@Vyshnav001 Better keep cost at the top of register button

But i think register button should be bottom of poster

@rabilrbl
Copy link
Member

rabilrbl commented May 1, 2024

Left alignment in large screen is fixed

image

@Vyshnav001
Copy link
Contributor Author

Left alignment in large screen is fixed

image

thanks @rabilrbl

@Vyshnav001
Copy link
Contributor Author

@Vyshnav001 Better keep cost at the top of register button

But i think register button should be bottom of poster

should i change the register button to the bottom of the poster?

@rabilrbl
Copy link
Member

rabilrbl commented May 1, 2024

@Vyshnav001 Better keep cost at the top of register button

But i think register button should be bottom of poster

should i change the register button to the bottom of the poster?

Check with Anish

@anishshobithps
Copy link
Member

@Vyshnav001 Better keep cost at the top of register button
But i think register button should be bottom of poster

should i change the register button to the bottom of the poster?

That should be fine, not a big deal, although I am not sure if I fan of the encrypt button tho, thoughts ? Other than everything is good for me

anishshobithps
anishshobithps previously approved these changes May 1, 2024
Copy link
Member

@anishshobithps anishshobithps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Register button is upto you, rest everything is good for me

@rabilrbl
Copy link
Member

rabilrbl commented May 2, 2024

@Vyshnav001 Better keep cost at the top of register button
But i think register button should be bottom of poster

should i change the register button to the bottom of the poster?

That should be fine, not a big deal, although I am not sure if I fan of the encrypt button tho, thoughts ? Other than everything is good for me

@anishshobithps i feel let the encrypt button looks fine, but I feel the previous placement at the bottom was better

Cc: @Vyshnav001

@Vyshnav001
Copy link
Contributor Author

@Vyshnav001 Better keep cost at the top of register button
But i think register button should be bottom of poster

should i change the register button to the bottom of the poster?

That should be fine, not a big deal, although I am not sure if I fan of the encrypt button tho, thoughts ? Other than everything is good for me

@anishshobithps i feel let the encrypt button looks fine, but I feel the previous placement at the bottom was better

Cc: @Vyshnav001

Button in the bottom was better

@rabilrbl
Copy link
Member

rabilrbl commented May 2, 2024

@Vyshnav001 Better keep cost at the top of register button
But i think register button should be bottom of poster

should i change the register button to the bottom of the poster?

That should be fine, not a big deal, although I am not sure if I fan of the encrypt button tho, thoughts ? Other than everything is good for me

@anishshobithps i feel let the encrypt button looks fine, but I feel the previous placement at the bottom was better

Cc: @Vyshnav001

Button in the bottom was better

Please push it. We have to merge

@Vyshnav001
Copy link
Contributor Author

@Vyshnav001 Better keep cost at the top of register button
But i think register button should be bottom of poster

should i change the register button to the bottom of the poster?

That should be fine, not a big deal, although I am not sure if I fan of the encrypt button tho, thoughts ? Other than everything is good for me

@anishshobithps i feel let the encrypt button looks fine, but I feel the previous placement at the bottom was better
Cc: @Vyshnav001

Button in the bottom was better

Please push it. We have to merge

done

@rabilrbl rabilrbl merged commit fb392ea into main May 2, 2024
3 checks passed
@rabilrbl rabilrbl deleted the cards branch May 2, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants