-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : Add Conditional Rendering for Event Prerequisites #42
Conversation
This reverts commit fb4c244.
sync main to cards
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Vyshnav001 What's the status of this PR? |
@Vyshnav001 We are not using this route in website anymore. @anishshobithps Any plans on enabling per event page? |
haa that's why i kept it as draft :) |
should i close the PR? |
No keep it. |
I don't mind, but I had disabled it, the preview doesn't take me to the per event page, or am I missing something ? |
Also, is every data entered in there ? |
Register now button is there and it is not linked ig |
but still that page can be accessed through the url |
@Vyshnav001 Can u please check if styling and css is proper for those pages. Also check mobile view. Then proceed to use CC: @anishshobithps |
done |
@anishshobithps check now |
|
@Vyshnav001 Better keep cost at the top of register button But i think register button should be bottom of poster |
thanks @rabilrbl |
should i change the register button to the bottom of the poster? |
Check with Anish |
That should be fine, not a big deal, although I am not sure if I fan of the encrypt button tho, thoughts ? Other than everything is good for me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Register button is upto you, rest everything is good for me
@anishshobithps i feel let the encrypt button looks fine, but I feel the previous placement at the bottom was better Cc: @Vyshnav001 |
Button in the bottom was better |
Please push it. We have to merge |
done |
No description provided.